Skip to content

fix: better match empty text fields#1181

Draft
kpodp0ra wants to merge 5 commits intoteableio:developfrom
kpodp0ra:fix/empty
Draft

fix: better match empty text fields#1181
kpodp0ra wants to merge 5 commits intoteableio:developfrom
kpodp0ra:fix/empty

Conversation

@kpodp0ra
Copy link
Contributor

Context

This filter doesn't match empty strings, it only looks for nulls in database.


Changes

  1. Add e2e test for empty strings.1
  2. Added empty string matching to isEmpty filter.

Before this PR, only the first item would be matched. Now it matches the first and second one.

Footnotes

  1. In order to maintain readability, instead of adding another item to e2e, I re-branded the 20th field.

@kpodp0ra kpodp0ra marked this pull request as draft December 20, 2024 14:20
@kpodp0ra
Copy link
Contributor Author

Working on aggregation fix:

@kpodp0ra
Copy link
Contributor Author

Waiting for 1183 issue to be resolved.

@teableio teableio deleted a comment from FuungKanchana Dec 28, 2024
tea-artist pushed a commit that referenced this pull request Feb 9, 2026
… (T1917) (#1181)

Synced from teableio/teable-ee@aebdff5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant